Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.77.0 #1813

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Release/0.77.0 #1813

merged 7 commits into from
Feb 22, 2024

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Feb 22, 2024

Duplicate of #1813 to master

dcshzj and others added 7 commits February 8, 2024 16:34
* fix(dompurify): further limit src

* fix(dompurify): rm unallowed src

* fix(scriptTag): disallow href
## Problem

Adding broken link checker to front end


## Solution

Adds in the main UI for the broken link checkers. This is not design approved, the alignment with @sehyunidaaa at the moment is that we will use this to experiment how quickly users are able to repair their sites on their own before polishing the UI and removing the feature flag as a whole. 


Note: the introduction of the feature flag is done in a downstream pr.


Main user page: 

https://github.com/isomerpages/isomercms-frontend/assets/42832651/f38e6e77-de50-4a75-88e1-c75df19009b7

Only entry point: 

https://github.com/isomerpages/isomercms-frontend/assets/42832651/7574a34c-41f4-4a21-bcdb-95a935ffce56



**Breaking Changes**

<!-- Does this PR contain any backward incompatible changes? If so, what are they and should there be special considerations for release? -->

- [ ] Yes - this PR contains breaking changes
  - Details ...
- [X] No - this PR is backwards compatible with ALL of the following feature flags in this [doc](https://www.notion.so/opengov/Existing-feature-flags-518ad2cdc325420893a105e88c432be5)



## Tests

<!-- What tests should be run to confirm functionality? -->


- [ ] Log in to staging via github
- [ ] Access the page `/sites/<site-name>/linkCheckerReport` for any site [here](https://github.com/isomerpages/isomer-site-checker/)
- [ ] Verify that the content is loading, and you are able to access the page in staging + you are able to go into a valid edit page
- [ ] Verify that when you click on the breadcrumbs on the side, it leads to the correct table (ie what was done in the video above) 

## Deploy Notes

Need to clone site-link checker into both prod and staging
* feat/feature-flag-link-checker

* fix(linkChecker): dont trip alarms
@alexanderleegs alexanderleegs requested a review from a team February 22, 2024 08:54
Copy link

mergify bot commented Feb 22, 2024

⚠️ The sha of the head commit of this PR conflicts with #1812. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

cypress bot commented Feb 22, 2024

57 failed tests on run #508 ↗︎

57 51 1 22 Flakiness 0

Details:

Release/0.77.0
Project: isomercms-frontend Commit: 9b4ef31297
Status: Failed Duration: 17:03 💡
Started: Feb 22, 2024 9:07 AM Ended: Feb 22, 2024 9:24 AM
Failed  editPage.spec.ts • 10 failed tests

View Output Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add link Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow users to add Instagram embed script Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should have correct colour Screenshots Video
editPage.spec > Edit resource page > Edit page (resource) should have correct colour Screenshots Video
Failed  files.spec.ts • 10 failed tests

View Output Video

Test Artifacts
Files > Create file, delete file, edit file settings in Files > Files should contain Directories and Ungrouped Files Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to create new file with valid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to delete file Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to create new file directory Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory Screenshots Video
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to add file to file directory Screenshots Video
Failed  folders.spec.ts • 9 failed tests

View Output Video

Test Artifacts
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder with a page Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder without page Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to create a new page with valid title and permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid title Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Chinese title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to delete existing page in folder Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to create a new page with valid title and permalink Screenshots Video
Failed  homepage.spec.ts • 6 failed tests

View Output Video

Test Artifacts
Homepage > Block editing > should display the site notification correctly Screenshots Video
Homepage > Block editing > should only allow up to 4 highlights for the hero section Screenshots Video
Homepage > Block editing > should remove the button in preview when the hero button content is not given Screenshots Video
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section Screenshots Video
Homepage > Block editing > should limit users to a single resource component Screenshots Video
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order Screenshots Video
Failed  images.spec.ts • 1 failed test

View Output Video

Test Artifacts
Images > Create album, delete album, edit album settings in Images > Should be able to create new album Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #1813 ↗︎

@alexanderleegs alexanderleegs merged commit 023f5b5 into master Feb 22, 2024
31 of 35 checks passed
@mergify mergify bot deleted the release/0.77.0 branch February 22, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants