-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.77.0 #1813
Merged
Merged
Release/0.77.0 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(dompurify): further limit src * fix(dompurify): rm unallowed src * fix(scriptTag): disallow href
## Problem Adding broken link checker to front end ## Solution Adds in the main UI for the broken link checkers. This is not design approved, the alignment with @sehyunidaaa at the moment is that we will use this to experiment how quickly users are able to repair their sites on their own before polishing the UI and removing the feature flag as a whole. Note: the introduction of the feature flag is done in a downstream pr. Main user page: https://github.com/isomerpages/isomercms-frontend/assets/42832651/f38e6e77-de50-4a75-88e1-c75df19009b7 Only entry point: https://github.com/isomerpages/isomercms-frontend/assets/42832651/7574a34c-41f4-4a21-bcdb-95a935ffce56 **Breaking Changes** <!-- Does this PR contain any backward incompatible changes? If so, what are they and should there be special considerations for release? --> - [ ] Yes - this PR contains breaking changes - Details ... - [X] No - this PR is backwards compatible with ALL of the following feature flags in this [doc](https://www.notion.so/opengov/Existing-feature-flags-518ad2cdc325420893a105e88c432be5) ## Tests <!-- What tests should be run to confirm functionality? --> - [ ] Log in to staging via github - [ ] Access the page `/sites/<site-name>/linkCheckerReport` for any site [here](https://github.com/isomerpages/isomer-site-checker/) - [ ] Verify that the content is loading, and you are able to access the page in staging + you are able to go into a valid edit page - [ ] Verify that when you click on the breadcrumbs on the side, it leads to the correct table (ie what was done in the video above) ## Deploy Notes Need to clone site-link checker into both prod and staging
* feat/feature-flag-link-checker * fix(linkChecker): dont trip alarms
|
alexanderleegs
temporarily deployed
to
staging
February 22, 2024 09:02 — with
GitHub Actions
Inactive
alexanderleegs
had a problem deploying
to
staging
February 22, 2024 09:04 — with
GitHub Actions
Failure
alexanderleegs
had a problem deploying
to
staging
February 22, 2024 09:04 — with
GitHub Actions
Failure
alexanderleegs
had a problem deploying
to
staging
February 22, 2024 09:04 — with
GitHub Actions
Failure
alexanderleegs
temporarily deployed
to
staging
February 22, 2024 09:05 — with
GitHub Actions
Inactive
kishore03109
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1813 to master